Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] website_sale_product_attribute_value_filter_existing: Migration to 18.0 #978

Open
wants to merge 24 commits into
base: 18.0
Choose a base branch
from

Conversation

pilarvargas-tecnativa
Copy link
Contributor

cc @Tecnativa TT51372

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 18.0-mig-website_sale_product_attribute_value_filter_existing branch from 4064d94 to 7d06b7d Compare October 24, 2024 09:05
CarlosRoca13 and others added 15 commits October 24, 2024 11:35
… to 15.0

[UPD] Update website_sale_product_attribute_value_filter_existing.pot
…nature

match the function signature of shop with the original one from
website_sale, to avoid potential issues with other modules overwriting
the function and passing unexpected parameters
…to check the real functionality of the module

TT45590
…ormance improvement

- Switch to setUpClass for avoiding repeat the same setup for each test.
- Include context keys for avoiding mail operations overhead.
…ibute parent container

If only the attribute container is hidden, the parent container still occupies a space that is visible in the attribute list. To avoid this, apply the condition to the parent container and hide it completely.

TT50704
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 18.0-mig-website_sale_product_attribute_value_filter_existing branch from 7d06b7d to 34bf7ec Compare October 24, 2024 09:35
@pilarvargas-tecnativa pilarvargas-tecnativa marked this pull request as ready for review October 24, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.